Implement SUBSTRING function pushdown for Teradata connector#37
Merged
Conversation
sc250072
requested changes
Sep 22, 2025
sc250072
left a comment
Collaborator
There was a problem hiding this comment.
Address the review comments.
…ng_Pushdown # Conflicts: # plugin/trino-teradata/src/main/java/io/trino/plugin/teradata/RewriteSubstring.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for pushing down the
SUBSTRINGfunction to the Teradata database, improving query performance by reducing data transfer and leveraging native database string processing capabilities.Changes Made:
RewriteSubstringFunctionclass to handleSUBSTRINGfunction projection pushdownRewriteSubstringclass for expression rewriting in predicatesTeradataClientexpression and projection function rewritersTechnical Details:
SUBSTRINGfunction syntax for optimal performanceAdditional context and related issues
Testing Considerations:
SUBSTRINGfunction works correctly with various string typesRelease notes
Teradata Connector Enhancements
New Features:
SUBSTRINGfunction calls to the database, improving query performance for string extraction operations.Performance Improvements:
SUBSTRINGfunction by leveraging native Teradata string processingTechnical Enhancements:
SUBSTRINGfunction in both predicate and projection contextsSUBSTRINGvariantsUsage Examples: